misc scripts: add support for arm64 by asylumexp · Pull Request #12639 · community-scripts/ProxmoxVE

asylumexp · 2026-03-07T05:45:42Z

✍️ Description

Adds support for creating arm64 Ubuntu, Debian, and alpine containers via scripts.

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

michelroegl-brunner

Looks like a solid solution to implement the ARM scripts in the repo. We then dont even need any special calls for the scripts when a user wants to run the arm version. I really like that. As i see for the install script, you just basicly put the arm needed stuff in front of the AMD64 install script?

CrazyWolf13

Was this tested in VED repo?

Should we consider adding a short whitail popup, that arm support is in beta or active development and there may be stuff that is not yet fully tested/working?

Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>

Legacy support removed since no cts use them anymore.

Add clearer architecture error messages and gate arm64 usage, plus implement architecture-aware behavior across the toolkit. Changes include: update exit-code messages to reference amd64/arm64, refuse arm64 unless explicitly enabled, show architecture in summaries, and use arch-specific package lists when installing in containers. Make downloads for FFmpeg and yq choose the correct amd64/arm64 binaries, tighten template download error handling and formatting, and clean up minor whitespace/comment issues. These changes aim to make arm64 handling explicit and downloads/installations more robust for non-amd64 systems.

tremor021 · 2026-05-12T11:34:59Z

I don't see any outstanding issues here. If @MickLesk agrees, we can merge this

CrazyWolf13

I don't see any issues with it, but @MickLesk is the most familiar with core

Copilot

Pull request overview

This PR extends the helper scripts’ architecture handling to (intendedly) support arm64 hosts/containers, including arm64-aware template fetching for Debian/Ubuntu/Alpine and arm64 binary selection for a few bundled tools.

Changes:

Update GitHub/Codeberg release asset selection heuristics to better distinguish amd64 vs arm64 .deb assets.
Add arm64-specific LXC template download flow (GitHub releases + linuxcontainers Jenkins rootfs) and wire it into container creation.
Add arm64-aware download URLs for selected tools (FFmpeg/yq) and adjust architecture validation messaging.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`misc/tools.func`	Refines release asset heuristics and adds arch-based FFmpeg/yq download selection.
`misc/error_handler.func`	Updates exit-code 106 description text to reflect amd64/arm64 support.
`misc/core.func`	Expands arch validation to include arm64, adds whiptail install helper + arm64 notice dialog.
`misc/build.func`	Adds ARM64 template defaults and implements custom arm64 template download/validation in LXC creation.
`misc/api.func`	Updates exit-code 106 description text to reflect amd64/arm64 support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MickLesk · 2026-05-12T12:24:53Z

We should prepare the Website (issue Template and Request form for arm64) the issue Template and some little Things. Maybe i have in the next week an arm64 Test Setup

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

michelroegl-brunner · 2026-06-01T14:28:57Z

@MickLesk what do you want changed on the website for that to get merged? i can tackle some things if you like.

MickLesk · 2026-06-01T14:50:53Z

Sure, you can. My brain is full this week 😄 and its fckn monday

michelroegl-brunner · 2026-06-08T14:29:29Z

@MickLesk review/approve when you got time pls

misc scripts: add support for arm64

087f817

asylumexp requested review from MickLesk and michelroegl-brunner March 7, 2026 05:45

github-actions Bot added core feature labels Mar 7, 2026

asylumexp commented Mar 7, 2026

View reviewed changes

Comment thread misc/install.func Outdated

Replace tools.func call that checks arch

6f62656

asylumexp commented Mar 7, 2026

View reviewed changes

Comment thread misc/tools.func

asylumexp marked this pull request as ready for review March 7, 2026 10:12

asylumexp requested a review from a team as a code owner March 7, 2026 10:12

michelroegl-brunner reviewed Mar 9, 2026

View reviewed changes

Comment thread misc/build.func Outdated

Comment thread misc/build.func Outdated

Comment thread misc/install.func Outdated

michelroegl-brunner previously approved these changes Mar 10, 2026

View reviewed changes

michelroegl-brunner requested review from CrazyWolf13 and tremor021 March 10, 2026 13:05

CrazyWolf13 previously requested changes Mar 10, 2026

View reviewed changes

Update misc/build.func

b9d401b

Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>

asylumexp dismissed michelroegl-brunner’s stale review via b9d401b March 10, 2026 23:56

asylumexp and others added 6 commits March 11, 2026 09:56

Update misc/build.func

e4db6be

Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>

Update misc/build.func

a6a83b9

Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>

Update misc/build.func

7897918

Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>

build.func: change back to VE

35b3b93

build.func: remove arm64 support for focal, bullseye

6f8aa6e

Legacy support removed since no cts use them anymore.

github-actions Bot added the api Changes to the API label Mar 11, 2026

MickLesk added 3 commits March 11, 2026 14:26

remove arm64 overlay

231945d

Merge branch 'main' into arm64-build-support

4ab3a24

update ifupdown2 source

44ec223

MickLesk requested review from CrazyWolf13 and michelroegl-brunner March 11, 2026 13:38

asylumexp marked this pull request as draft March 12, 2026 03:11

michelroegl-brunner previously approved these changes May 12, 2026

View reviewed changes

asylumexp mentioned this pull request May 12, 2026

[ARM64] Setting scripts that need no changes to compatible with ARM64 #14438

Closed

10 tasks

tremor021 previously approved these changes May 12, 2026

View reviewed changes

CrazyWolf13 previously approved these changes May 12, 2026

View reviewed changes

CrazyWolf13 requested a review from Copilot May 12, 2026 12:02

Copilot started reviewing on behalf of CrazyWolf13 May 12, 2026 12:03 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Potential fix for pull request finding

16ac440

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

asylumexp dismissed stale reviews from CrazyWolf13, tremor021, and michelroegl-brunner via 16ac440 May 12, 2026 14:45

asylumexp and others added 2 commits May 13, 2026 00:46

Potential fix for pull request finding

2c1f216

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix for copilot detected bugs

88a6b07

asylumexp force-pushed the arm64-build-support branch from 5ec219a to 88a6b07 Compare May 12, 2026 14:57

This was referenced May 22, 2026

workflows: update workflows, templates to support arm64. #14653

Merged

workflows: add arm64 support considerations community-scripts/ProxmoxVED#1854

Merged

michelroegl-brunner approved these changes Jun 8, 2026

View reviewed changes

michelroegl-brunner requested review from CrazyWolf13, michelroegl-brunner and tremor021 June 8, 2026 14:28

michelroegl-brunner approved these changes Jun 11, 2026

View reviewed changes

MickLesk approved these changes Jun 11, 2026

View reviewed changes

MickLesk merged commit 6851a02 into main Jun 11, 2026
1 check passed

asylumexp added the arm64 label Jun 18, 2026

github-actions Bot locked as resolved and limited conversation to collaborators Jun 26, 2026

Uh oh!

Uh oh!

Conversation

asylumexp commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✍️ Description

✅ Prerequisites (X in brackets)

🛠️ Type of Change (X in brackets)

Uh oh!

Uh oh!

Uh oh!

michelroegl-brunner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CrazyWolf13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tremor021 commented May 12, 2026

Uh oh!

CrazyWolf13 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MickLesk commented May 12, 2026

Uh oh!

michelroegl-brunner commented Jun 1, 2026

Uh oh!

MickLesk commented Jun 1, 2026

Uh oh!

michelroegl-brunner commented Jun 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

asylumexp commented Mar 7, 2026 •

edited

Loading